Fix 'path ... does not exist' false-positive for expr containing DIRECTORY_SEPARATOR - #6035
Merged
Conversation
staabm
marked this pull request as ready for review
July 11, 2026 07:23
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root problem was that
DIRECTORY_SEPARATORwas resolved into'\\'|’/'which made it duplicate errors when paths later on where build with both variants. this also lead to the 'crazy' result of seeing windows-style path separators in errors on linux based systems and vice-versa.closes phpstan/phpstan#14944
closes #6027